JavaScript slider function not working when self invoked

Cyzanfar

I'm trying to implement a slider using Javascript only (no external libraries like jQuery).

Here is my HTML file:

<!DOCTYPE html>
<html>
<head>
    <title></title>
    <!-- Latest compiled and minified CSS -->
<script language="javascript" type="text/javascript" src="slider.js"></script>
<link rel="stylesheet" href="stylesheet.css">
<link rel="stylesheet" href="https://maxcdn.bootstrapcdn.com/bootstrap/3.3.4/css/bootstrap.min.css">
</head>
<body>

<div class="container main-container">
    <div id="container">
        <img id='slider-img' src='images/img1.png'>
        <div id='left_holder'><img onclick="slider(-1)" class='left' src="images/arrow_left.png"></div>
        <div id='right_holder'><img onclick="slider(1)" class='right' src="images/arrow_right.png"></div>
    </div>
</div>

</body>
</html>

JS slider file:

(function() {
    slider();

})();

    function slider(element) {
        var imagecount = 1;
        var totalimage = 11;
        var image = document.getElementById("slider-img");
        imagecount = imagecount + element;
        image.src = "images/img" + imagecount + ".png";
    }

I'm getting an error at image.src cannot set property src of null because document.getElementById("slider-img"); can't get the element img of the html code. Anybody have some insight on this issue?

guest271314

var imagecount = 1;
function slider(element) {
  var totalimage = 11;
  var image = document.getElementById("slider-img");
  imagecount = imagecount < totalimage ? imagecount + Number(element) : 1;
  if (imagecount < 1) {
    imagecount = 1;
  };
  image.src = "images/img" + imagecount + ".png";
  console.log(imagecount)
}

window.onload = function() {
  slider(0)
}
<!DOCTYPE html>
<html>

<head>
  <title></title>
  <!-- Latest compiled and minified CSS -->
  <script language="javascript" type="text/javascript" src="slider.js"></script>
  <link rel="stylesheet" href="stylesheet.css">
  <link rel="stylesheet" href="https://maxcdn.bootstrapcdn.com/bootstrap/3.3.4/css/bootstrap.min.css">
</head>

<body>

  <div class="container main-container">
    <div id="container">
      <img id='slider-img' src='images/img1.png'>
      <div id='left_holder'>
        <img onclick="slider(-1)" class='left' src="images/arrow_left.png">
      </div>
      <div id='right_holder'>
        <img onclick="slider(1)" class='right' src="images/arrow_right.png">
      </div>
    </div>
  </div>

</body>

</html>

Collected from the Internet

Please contact [email protected] to delete if infringement.

edited at
0

Comments

0 comments
Login to comment

Related

self invoked function closures inJavaScript

When is JavaScript function expression invoked/executed/called in this following code?

Javascript self invoking function not working in angular ionic

ajax self invoked function to vue data

This of inner function when invoked by call

function runs only when invoked?

JavaScript function is invoked without parenthesis?

Immediately Invoked Function Expression in javascript

javascript slider not working

JavaScript slider not working as expected

Writing a Scala function that returns a function when invoked

jQuery blockUI() is NOT working when invoked on beforeSend

Valid script not working when invoked as npm script

JavaScript Wrapper Function - inner function not invoked

hasClass() function not working as intended in a slider

what cpp function in firefox gets invoked when javascript invokes clipboard.getData()?

JavaScript function in external HTML file not invoked when an object is passed as parameter from an Angular2 component

Why is my Javascript function not being called when I have invoked it in OnClientClick

Why doesn't this JS self-invoked function work?

Why this function is not invoked when calling jQuery Plugin

Getting undefined result when invoked function

Self hosted Wcf serves wsdl but 404's when invoked

javascript SetTimeout only invoked at function exit

javascript - why is declared function invoked at runtime

Javascript closure and IIFE (immediately invoked function expressions)

Javascript image slider not working properly

Buttons in slider not working using javascript

JavaScript - Image slider buttons not working

Autoplay not working on my Javascript Slider