C++ program crashes while checking if a pointer is NULL using if condition

Vaibhav Jain

I was trying a C program on queue as a linked list. Whenever I try to execute, it crashes whenever it encounters if condition comparing a pointer (q->f in this case) with NULL. Please check the following code:

#include<stdio.h>
using namespace std;
struct node
{
    int info;
    node *next;
};
struct que
{
    struct node *f; //front
    struct node *r; //rear
    que()
    {
        f=r=NULL; //initialize as NULL
    }
};
struct que *pq;
/* prototypes */
void disp(struct que *q);
int emp(struct que *q);
void ins(struct que *q,int x);
void del(struct que *q);

int main()
{
    int cho;
    while(1)    //so that it executes continuously and I can exit whenever I want
    {
        printf("Enter 1 to insert in a queue\n");
        printf("Enter 2 to delete in a queue\n");
        printf("Enter 3 to display the queue\n");
        scanf("%d",&cho);
        if (cho==1)
        {
            int x;
            printf("Enter the info to be added\n");
            scanf("%d",&x);
            ins(pq,x);
        }
        else if (cho==2)
            del(pq);
        else if (cho==3)
            disp(pq);
    }
    return 0;
}
int emp(struct que *q) // Check whether queue is empty or not
{
    return ((q->f==NULL)?1:0); //Error
}
void ins(struct que *q,int a)
{
    node *p;
    p=new node;
    p->info=a;
    p->next=NULL;
    if ((q->r)==NULL)   //Error. I get crash and this statement is never executed.
        (q->f)=p;
    else
        (q->r)->next=p;
    (q->r)=p;
    printf("Node added\n");
}
void del(struct que *q)
{
    node *p=NULL;
    if (emp(q))
    {
        printf("Empty queue.Insert some elements\n");
        return;
    }
    p=q->f;
    q->f=p->next;
    delete p;
    printf("Node deleted\n");
}
void disp(struct que *q)
{
    if (emp(q))
    {
        printf("Empty queue.Insert some elements\n");
        return;
    }
    node *i=NULL;
    for (i=q->f;i!=NULL;i=(i)->next)
        printf("%d\n",i->info);
}

I suspect there's something wrong with the statement if ((q->r)==NULL). Executing the program results in a crash " has stopped working". I have also tried replacing it with if (!q->r) , but without much success. I am unable to find a problem in my code.Please help me..Thanks

NPE

You never initialize pq, so q->r in the following has undefined behaviour:

if ((q->r)==NULL)   //Error. I get crash and this statement is never executed.

One way to fix this is by turning

struct que *pq;

into

struct que pq;

and then passing &pq into ins() et al.

Collected from the Internet

Please contact [email protected] to delete if infringement.

edited at
0

Comments

0 comments
Login to comment

Related

TOP Ranking

  1. 1

    Failed to listen on localhost:8000 (reason: Cannot assign requested address)

  2. 2

    Loopback Error: connect ECONNREFUSED 127.0.0.1:3306 (MAMP)

  3. 3

    How to import an asset in swift using Bundle.main.path() in a react-native native module

  4. 4

    pump.io port in URL

  5. 5

    Compiler error CS0246 (type or namespace not found) on using Ninject in ASP.NET vNext

  6. 6

    BigQuery - concatenate ignoring NULL

  7. 7

    ngClass error (Can't bind ngClass since it isn't a known property of div) in Angular 11.0.3

  8. 8

    ggplotly no applicable method for 'plotly_build' applied to an object of class "NULL" if statements

  9. 9

    Spring Boot JPA PostgreSQL Web App - Internal Authentication Error

  10. 10

    How to remove the extra space from right in a webview?

  11. 11

    java.lang.NullPointerException: Cannot read the array length because "<local3>" is null

  12. 12

    Jquery different data trapped from direct mousedown event and simulation via $(this).trigger('mousedown');

  13. 13

    flutter: dropdown item programmatically unselect problem

  14. 14

    How to use merge windows unallocated space into Ubuntu using GParted?

  15. 15

    Change dd-mm-yyyy date format of dataframe date column to yyyy-mm-dd

  16. 16

    Nuget add packages gives access denied errors

  17. 17

    Svchost high CPU from Microsoft.BingWeather app errors

  18. 18

    Can't pre-populate phone number and message body in SMS link on iPhones when SMS app is not running in the background

  19. 19

    12.04.3--- Dconf Editor won't show com>canonical>unity option

  20. 20

    Any way to remove trailing whitespace *FOR EDITED* lines in Eclipse [for Java]?

  21. 21

    maven-jaxb2-plugin cannot generate classes due to two declarations cause a collision in ObjectFactory class

HotTag

Archive