String function returning empty string C++

Tristan Ferrua Edwardsson

I'm trying to make a function which converts a number to binary in C++ but whenever I call the function it returns an empty string.

Here is my code:

#include <iostream>
#include <stdio.h>
#include <vector>
#include <string.h>
#include <math.h>
#include <algorithm>

using namespace std;

string dec2bin(long long x, vector<long long> extra = { }) {

    string out;
    string output;
    int i = 0;
    long long sum = 0;
    bool ok = false;

    if(!extra.empty()) {
        for(int a = 0; a < extra.end() - extra.begin(); a++) {
            sum += pow(2, extra[a]);
        }
    }

    while(pow(2, i) + sum < x) {
        i++;
    }
    if(i > 0) {
        i--;
    }
    extra.push_back(i);

    if(pow(2, i) + sum == x) {

        long long max = *max_element(extra.begin(), extra.end());

        for(int a = max; a >= 0; a--) {
            if(std::find(extra.begin(), extra.end(), a) < extra.end()) {
                out += '1';
            }
            else {
                out += '0';
            }
        }
        ok = true;
    }

    if(ok) {
        return out;
    }
    else {
        dec2bin(x, extra);
    }
}

int main() {

    long long a;
    cin >> a;

    cout << dec2bin(a) << endl;

    return 0;

}

If I add a line containing cout << out << endl; before the return statement, it prints out the string. Any help is much appreciated :)

DimChtz

Under else change dec2bin(x, extra); to:

   return dec2bin(x, extra);

I think that's your problem.

Collected from the Internet

Please contact [email protected] to delete if infringement.

edited at
0

Comments

0 comments
Login to comment

Related

TOP Ranking

  1. 1

    Failed to listen on localhost:8000 (reason: Cannot assign requested address)

  2. 2

    Loopback Error: connect ECONNREFUSED 127.0.0.1:3306 (MAMP)

  3. 3

    How to import an asset in swift using Bundle.main.path() in a react-native native module

  4. 4

    pump.io port in URL

  5. 5

    Compiler error CS0246 (type or namespace not found) on using Ninject in ASP.NET vNext

  6. 6

    BigQuery - concatenate ignoring NULL

  7. 7

    ngClass error (Can't bind ngClass since it isn't a known property of div) in Angular 11.0.3

  8. 8

    ggplotly no applicable method for 'plotly_build' applied to an object of class "NULL" if statements

  9. 9

    Spring Boot JPA PostgreSQL Web App - Internal Authentication Error

  10. 10

    How to remove the extra space from right in a webview?

  11. 11

    java.lang.NullPointerException: Cannot read the array length because "<local3>" is null

  12. 12

    Jquery different data trapped from direct mousedown event and simulation via $(this).trigger('mousedown');

  13. 13

    flutter: dropdown item programmatically unselect problem

  14. 14

    How to use merge windows unallocated space into Ubuntu using GParted?

  15. 15

    Change dd-mm-yyyy date format of dataframe date column to yyyy-mm-dd

  16. 16

    Nuget add packages gives access denied errors

  17. 17

    Svchost high CPU from Microsoft.BingWeather app errors

  18. 18

    Can't pre-populate phone number and message body in SMS link on iPhones when SMS app is not running in the background

  19. 19

    12.04.3--- Dconf Editor won't show com>canonical>unity option

  20. 20

    Any way to remove trailing whitespace *FOR EDITED* lines in Eclipse [for Java]?

  21. 21

    maven-jaxb2-plugin cannot generate classes due to two declarations cause a collision in ObjectFactory class

HotTag

Archive