使用帶有 select() 的套接字編程的聊天室 - winsock - C

加密圖克

我嘗試創建一個服務器-客戶端應用程序,其中服務器為連接到服務器的所有客戶端提供聊天服務。服務器和客戶端使用加密算法和協議來保護通過網絡傳輸的數據。我不明白為什麼聊天代碼不能正常工作。

我使用該select()功能同時操作多個抽屜。如果當多個客戶端連接到服務器並將數據發送到服務器時我只使用一段代碼並且它得到了一切,那很好,但是一旦我嘗試編寫一段將成為聊天功能的代碼,即使多個客戶端連接,服務器只服務最後連接的客戶端。我使用鏈接動態列表來存儲必要的客戶端信息,當我可以列出當前連接的客戶端時,如果我不使用部分聊天室代碼,我連接的所有客戶端都會被接受,並且一旦我使用聊天室代碼部分,只有最後連接的客戶端。

這是服務器的代碼:

 while(1) {
        fd_set reads;
        reads = master;

        //The select function determines the status of one or more sockets, waiting if necessary, to perform synchronous I/O
        if (select(max_socket+1, &reads, 0, 0, 0) < 0) {
            fprintf(stderr, "select() failed. (%d)\n", GETSOCKETERRNO());
            return 1;
        }

        SOCKET i;
        //Loop through each possible socket 
        for(i = 1; i <= max_socket; ++i) {
            if (FD_ISSET(i, &reads)) {

                //If socket_listen, create TCP connection of accept() function
                 if (i == socket_listen) {
                    //
                    client_info = create_client();
                    client_info->client_len = sizeof(client_info->client_address);
                    client_info->sock_fd = accept(socket_listen,
                            (struct sockaddr*) &client_info->client_address,
                            &client_info->client_len);

                    if (!ISVALIDSOCKET(client_info->sock_fd)) {
                        fprintf(stderr, "accept() failed. (%d)\n",
                                GETSOCKETERRNO());
                        return 1;
                    }

                    FD_SET(client_info->sock_fd, &master);
                    if (client_info->sock_fd > max_socket)
                        max_socket = client_info->sock_fd;
                
                    //Prints the client address using the getnameinfo() function
                    getnameinfo((struct sockaddr*)&client_info->client_address,
                            client_info->client_len,
                            client_info->address_buffer, 
                            100, 0, 0,
                            NI_NUMERICHOST);
                    printf("New connection %s\n", client_info->address_buffer);
                    

                    printf("\nWaiting for succeses Salt handshake...\n");

                    //Salt handshake 
                    salt_hndshk(client_info);

                    //Insert client to the list of clients
                    insert(p_list, client_info);

                    //List of clients connected to the server with a successful Salt handshake       
                    listing_clients(p_list);
      
                } else {
                    
                    memset(rx_buffer, 0, sizeof(hndsk_buffer));

                    //Search for clients by sockets and the is in the list
                    //the server decrypts the data from the client

                    CLIENT *client_decrypt = create_client();

                    client_decrypt = search_client(p_list, i);

                    ret_msg = salt_read_begin_pom(&client_decrypt->channel, rx_buffer, 
                                       sizeof(rx_buffer), &msg_in, pom_buffer, &decrypt_size);
                       
                    //Check if SALT_ERROR from message
                   if(ret_msg == SALT_ERROR) {
                        printf("\tThe client disconnects from the server.\n");
                        printf("\tThe server has closed him socket\n");
                        realese_client(p_list, client_decrypt);
                        FD_CLR(i, &master);
                        CLOSESOCKET(i);
                        continue;
                    }

                    //Freeing client memory
                    free(client_decrypt);
                }

            //Chat room service 
                
                SOCKET j;
                    for(j = 1; j <= max_socket; ++j){
                        if(FD_ISSET(j, &master)){
                            if (j == socket_listen || j == i){
                                continue;

                            } else {
                                memset(rx_buffer, 0, sizeof(hndsk_buffer));

                                //Search for clients by sockets and the is in the list
                                CLIENT *client_encrypt = create_client();
                                client_encrypt = search_client(p_list, j);

                                //Prepare data before send
                                salt_write_begin(tx_buffer, sizeof(tx_buffer), &msg_out);

                                //Copy clear text message to be encrypted to next encrypted package
                                salt_write_next(&msg_out, (uint8_t * )pom_buffer, decrypt_size);

                                //Wrapping, creating encrpted messages
                                salt_write_execute(&client_encrypt->channel, &msg_out, false);

                                //Freeing client memory
                                free(client_encrypt);
                            }
                            
                        } //if(FD_ISSET(j, &master)
                    } //for(j = 1; j <= max_socket; ++j)
                   
            //Finish chat room service

            } //if FD_ISSET
        } //for i to max_socket
    }

此鏈接上有一個指向該應用程序的鏈接:

tcp_salt

雷米勒博

您的兩個內部for循環都存在邏輯錯誤

從非偵聽客戶端套接字讀取/寫入時create_client(),根本不要調用,您正在使用它創建內存洩漏:

CLIENT *client_decrypt = create_client();
client_decrypt = search_client(...); // <-- LEAK!
CLIENT *client_encrypt = create_client();
client_encrypt = search_client(...); // <-- LEAK!

create_client()僅當您accept()是新客戶時才致電並且不要調用您讀取/寫入的free()任何CLIENT內容。僅當您CLIENT中刪除 a 時才調用它p_list

p_list在每次循環迭代中都破壞了你的,留下一堆指向無效CLIENTs的懸空指針

此外,您編寫的代碼不會檢查錯誤以斷開連接和刪除死客戶端。

嘗試更像這樣的事情:

while(1) {
    fd_set reads;
    reads = master;

    //The select function determines the status of one or more sockets, waiting if necessary, to perform synchronous I/O
    if (select(max_socket+1, &reads, 0, 0, 0) < 0) {
        fprintf(stderr, "select() failed. (%d)\n", GETSOCKETERRNO());
        return 1;
    }

    //Loop through each possible socket 
    for(SOCKET i = 1; i <= max_socket; ++i) {
        if (!FD_ISSET(i, &master)) {
            continue;
        }
        if (FD_ISSET(i, &reads)) {

            //If socket_listen, create TCP connection of accept() function
            if (i == socket_listen) {
                //
                CLIENT *client_info = create_client();
                client_info->client_len = sizeof(client_info->client_address);
                client_info->sock_fd = accept(socket_listen,
                        (struct sockaddr*) &client_info->client_address,
                        &client_info->client_len);

                if (!ISVALIDSOCKET(client_info->sock_fd)) {
                    fprintf(stderr, "accept() failed. (%d)\n",
                            GETSOCKETERRNO());
                    return 1;
                }

                FD_SET(client_info->sock_fd, &master);
                if (client_info->sock_fd > max_socket)
                    max_socket = client_info->sock_fd;
            
                //Prints the client address using the getnameinfo() function
                getnameinfo((struct sockaddr*)&client_info->client_address,
                        client_info->client_len,
                        client_info->address_buffer, 
                        100, 0, 0,
                        NI_NUMERICHOST);
                printf("New connection %s\n", client_info->address_buffer);

                printf("\nWaiting for succesful Salt handshake...\n");

                //Salt handshake 
                salt_hndshk(client_info);

                //Insert client to the list of clients
                insert(p_list, client_info);

                //List of clients connected to the server with a successful Salt handshake       
                listing_clients(p_list);

                continue;
            }
                
            memset(rx_buffer, 0, sizeof(rx_buffer));

            //Search for clients by sockets and the is in the list
            //the server decrypts the data from the client

            CLIENT *client_decrypt = search_client(p_list, i);

            ret_msg = salt_read_begin_pom(&client_decrypt->channel, rx_buffer, 
                                   sizeof(rx_buffer), &msg_in, pom_buffer, &decrypt_size);
                   
            //Check if SALT_ERROR from message
            if (ret_msg == SALT_ERROR) {
                printf("\tThe client disconnects from the server.\n");
                printf("\tThe server has closed his socket\n");
                release_client(p_list, client_decrypt);
                free(client_decrypt);
                CLOSESOCKET(i);
                FD_CLR(i, &master);
                continue;
            }

            //Chat room service 
            for(SOCKET j = 1; j <= max_socket; ++j){
                if (!FD_ISSET(j, &master) || j == socket_listen || j == i){
                    continue;
                }

                memset(rx_buffer, 0, sizeof(rx_buffer));

                //Search for clients by sockets and the is in the list
                CLIENT *client_encrypt = search_client(p_list, j);

                //Prepare data before send
                ret_msg = salt_write_begin(tx_buffer, sizeof(tx_buffer), &msg_out);

                //Copy clear text message to be encrypted to next encrypted package
                if (ret_msg != SALT_ERROR)
                    ret_msg = salt_write_next(&msg_out, (uint8_t * )pom_buffer, decrypt_size);

                //Wrapping, creating encrpted messages
                if (ret_msg != SALT_ERROR
                    ret_msg = salt_write_execute(&client_encrypt->channel, &msg_out, false);

                //Check if SALT_ERROR from message
                if (ret_msg == SALT_ERROR) {
                    printf("\tThe client disconnects from the server.\n");
                    printf("\tThe server has closed his socket\n");
                    release_client(p_list, client_decrypt);
                    free(client_decrypt);
                    CLOSESOCKET(i);
                    FD_CLR(i, &master);
                    continue;
                }
            }
        } 
    }
}

本文收集自互联网,转载请注明来源。

如有侵权,请联系 [email protected] 删除。

编辑于
0

我来说两句

0 条评论
登录 后参与评论

相关文章